[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 20 00:29:05 PDT 2023


MaskRay added a comment.

`registerTargetGlobalVariable` has a iteration order issue using StringMap, caught by D155789 <https://reviews.llvm.org/D155789>

  curl -L 'https://reviews.llvm.org/D155789?download=1' | patch -p1
  cmake ... -DLLVM_ENABLE_REVERSE_ITERATION=on
  ninja -C ... check-llvm-unit  #  `LLVM-Unit :: Frontend/./LLVMFrontendTests/OpenMPIRBuilderTest/registerTargetGlobalVariable` fails


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149162/new/

https://reviews.llvm.org/D149162



More information about the cfe-commits mailing list