[PATCH] D155729: [OptTable] Make explicitly included options override excluded ones

Wed Jul 19 14:27:37 PDT 2023

bogner added inline comments.

================
Comment at: clang/include/clang/Driver/Options.h:40
+  Ignored = (1 << 18),
+  TargetSpecific = (1 << 19),
 };
----------------
bob80905 wrote:
> Given that the id for these flags have changed, does it make sense to write a test that makes sure these flags with these bits still behave as expected? (Ignored and target specific, specifically).
The actual values of the flags aren't really visible anywhere (and in the case of ignored, it's actually just changing the value back to what it was before https://reviews.llvm.org/D128462). I'm not sure that there's much we can do to write such a test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155729/new/

https://reviews.llvm.org/D155729