[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

Michael Halkenhäuser via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 19 11:21:42 PDT 2023


mhalk added a comment.

As far as I can tell, no.
This *should* already be covered by Ndeps + DepList from `__tgt_interop_init`'s signature:
__tgt_interop_init(ident_t *LocRef, kmp_int32 Gtid,

  [...],
  kmp_int32 Ndeps, kmp_depend_info_t *DepList,
  kmp_int32 HaveNowait)

Which is very similar to the signature of `__kmpc_omp_taskwait_deps_51` -- which also uses the result of `buildDependences`:
__kmpc_omp_taskwait_deps_51(ident_t *loc_ref, kmp_int32 gtid,

  kmp_int32 ndeps, kmp_depend_info_t *dep_list,
  [...], kmp_int32 has_no_wait);

I guess the naming should be improved, changed that to `DependenceList`.
And I did not set the `HasNowaitClause` correctly, will update immediately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155692/new/

https://reviews.llvm.org/D155692



More information about the cfe-commits mailing list