[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

Wed Jul 19 09:37:32 PDT 2023

aaron.ballman added a comment.

In D142609#4513478 <https://reviews.llvm.org/D142609#4513478>, @xgupta wrote:

> Thanks, @nickdesaulniers for reviewing and @nathanchance for testing the change.
>
> @aaron.ballman, I also agree with @xbolva00 seems warning in kernel code is valid but I also agree with your comment about macro, may be better to track the macro-related issue with another GitHub issue.

SGTM! I've filed it in https://github.com/llvm/llvm-project/issues/63963

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142609/new/

https://reviews.llvm.org/D142609