[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

[Corentin Jabot via Phabricator via cfe-commits]

cor3ntin marked an inline comment as done.
cor3ntin added inline comments.


================
Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2730-2734
+DEF_TRAVERSE_STMT(CXXDefaultInitExpr, {
+  if (getDerived().shouldVisitImplicitCode())
+    TRY_TO(TraverseStmt(S->getExpr()));
+})
+
----------------
Note this is one of the reasons we didn;t get better diagnostics. It's adding there assuming this was an oversight.
Indeed, i see no reason  CXXDefaultInitExpr should not be traversed if CXXDefaultArgExpr should.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155175/new/

https://reviews.llvm.org/D155175