[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6986
+    DependenceAddress = DependenciesArray.getPointer();
+    CodeGenFunction::RunCleanupsScope LocalScope(*this);
   }
----------------
mhalk wrote:
> Not sure if this is useful here.
> Saw this `RunCleanupsScope` in conjunction with the emission of dependences + calls.
> 
> But, at least in the generated IR it won't remove duplicate `depend` clauses.
> 
> If anybody can comment on this, that would be great.
> Otherwise, I'd tend to remove it.
Not required here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155692/new/

https://reviews.llvm.org/D155692