[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

Mariya Podchishchaeva via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 19 02:37:49 PDT 2023


Fznamznon added inline comments.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:18441
       SemaRef.Diag(ND->getLocation(), diag::note_declared_at);
+      if (auto Context =
+              SemaRef.InnermostDeclarationWithDelayedImmediateInvocations()) {
----------------
cor3ntin wrote:
> Fznamznon wrote:
> > I would prefer spelling type here.
> that's an `std::optional<ExpressionEvaluationContextRecord::InitializationContext>`, I'm not sure spelling it improved readability. But i can change it!
Uh, yeah, doesn't seem to be improving readability. NVM :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155175/new/

https://reviews.llvm.org/D155175



More information about the cfe-commits mailing list