[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

Wang Pengcheng via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 19 00:11:29 PDT 2023


wangpc planned changes to this revision.
wangpc added a comment.

I don't have any thoughts on this patch now.

In D125765#4511637 <https://reviews.llvm.org/D125765#4511637>, @eopXD wrote:

> Sorry for the late reply, I missed this in may mails.
>
> I see that the motivation start from where you spotted this type alias. However it was essentially just an act for convenience so we don't have to map a more irregular pattern of ( _Float16, float, double) when generating the test cases by code. Is it necessary that we have them in the header? On the other hand, these are scalar floating-point types, and if we want them to be defined, I agree with Zakk that starting a discussion in riscv-c-api will be helpful.

Yeah, I agree. But I won't continue this now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125765/new/

https://reviews.llvm.org/D125765



More information about the cfe-commits mailing list