[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

Wed Jul 19 00:06:05 PDT 2023

tbaeder added a comment.

In D155627#4513433 <https://reviews.llvm.org/D155627#4513433>, @cor3ntin wrote:

> Note that you are probably need something like `SourceLocExprScopeGuard` to make source_location actually work, , it might be worth doing in this patch.
> The idea is to remember the location of a call when evaluating default arguments / default member initializers

Yeah I saw, that's what the FIXME comment is about.

================
Comment at: clang/test/AST/Interp/builtin-functions.cpp:153
+  static_assert(__builtin_LINE() == 152, "");
+}
----------------
cor3ntin wrote:
> what is missing to enable the existing source location tests with the new intterpreter?
There is a crash that I need to investigate first, //but// `SemaCXX/source_location.cpp` also uses stuff like `static_assert(noexcept(...));` that I don't handle yet.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155627/new/

https://reviews.llvm.org/D155627