[PATCH] D155670: [c-index-test] Suppress -Wcast-qual after D153911

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 18 19:42:44 PDT 2023


MaskRay created this revision.
MaskRay added reviewers: AlexM, dblaikie.
Herald added a subscriber: arphaman.
Herald added a project: All.
MaskRay requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

free_remapped_files needs to discard the casts qualifier.
index_startedTranslationUnit casts a string literal to void *.

Since we probably cannot change the public API, suppress the warnings.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155670

Files:
  clang/tools/c-index-test/c-index-test.c


Index: clang/tools/c-index-test/c-index-test.c
===================================================================
--- clang/tools/c-index-test/c-index-test.c
+++ clang/tools/c-index-test/c-index-test.c
@@ -230,10 +230,17 @@
 void free_remapped_files(struct CXUnsavedFile *unsaved_files,
                          int num_unsaved_files) {
   int i;
+#ifdef __GNUC__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wcast-qual"
+#endif
   for (i = 0; i != num_unsaved_files; ++i) {
     free((char *)unsaved_files[i].Filename);
     free((char *)unsaved_files[i].Contents);
   }
+#ifdef __GNUC__
+#pragma GCC diagnostic pop
+#endif
   free(unsaved_files);
 }
 
@@ -3759,7 +3766,14 @@
   printCheck(index_data);
 
   printf("[startedTranslationUnit]\n");
+#ifdef __GNUC__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wcast-qual"
+#endif
   return (CXIdxClientContainer)"TU";
+#ifdef __GNUC__
+#pragma GCC diagnostic pop
+#endif
 }
 
 static void index_indexDeclaration(CXClientData client_data,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155670.541818.patch
Type: text/x-patch
Size: 1025 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230719/28579f67/attachment.bin>


More information about the cfe-commits mailing list