[PATCH] D154880: [-Wunsafe-buffer-usage][WIP] Add a facility for debugging low fixit coverage.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 18 16:01:32 PDT 2023


NoQ added inline comments.


================
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2248-2249
+#ifndef NDEBUG
+        // FIXME: F->getBaseStmt() should never be null!
+        // (Or we should build a better interface for this.)
+        Handler.addDebugNoteForVar(
----------------
This is my original comment right? It's actually also outdated and should be removed, I already erased the runtime check, and I already moved the architectural recommendation to implementation of `getBaseStmt()` in individual gadgets for which it doesn't make sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154880/new/

https://reviews.llvm.org/D154880



More information about the cfe-commits mailing list