[PATCH] D147955: [clang-tidy] Extend CheckOptions to support grouping checks options

[Carlos Galvez via Phabricator via cfe-commits]

carlosgalvezp requested changes to this revision.
carlosgalvezp added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:94-95
+    // Nested option names need to be converted to null terminated strings for
+    // yaml serialization
+    llvm::SmallString<64> Buffer;
+    auto ToCString = [&Buffer](StringRef Str) {
----------------
This function has become very large and hard to read. Would it be possible to split it into subfunctions so it's easier to follow? I think it would make sense to create 1 function per different format supported (I believe with this patch there's now 3 different formats supported).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147955/new/

https://reviews.llvm.org/D147955