[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

[Matthew Voss via Phabricator via cfe-commits]

ormris added a comment.

> You can be more specific that multi-module bitcode files are for -fsanitize=cfi and -fwhole-program-vtables. And it will be more useful to include an example in the summary.

Fixed.

> This is a bit odd as the -o file may no longer an output. This could be fixed, but is this functionality really useful?

I think it's useful to allow this kind of disassembly. Users who want to quickly inspect a bitcode files produced by the compiler could run them through clang first. While llvm-dis is the normal tool to do this, but some users don't know or have access to llvm-dis.

> The nicer thing is that llvm-dis additionally calls ModuleSummaryIndex::print to print the module summary index (if present).

True, though this functionality could be added. I think users are more likely to be concerned about how their code was optimized by the LTO pre-link pipeline, say, then what the summary contains.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153906/new/

https://reviews.llvm.org/D153906