[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

Tue Jul 18 10:42:28 PDT 2023

efriedma added inline comments.

================
Comment at: flang/lib/Decimal/CMakeLists.txt:54
+
+if (DEFINED LLVM_ENABLE_PROJECTS AND "flang" IN_LIST LLVM_ENABLE_PROJECTS)
+  add_flang_library(FortranDecimal
----------------
I think it would make sense to use explicit CMake variables for the "if' statements (i.e. make flang/CMakeLists.txt define BUILDING_FLANG, and make flang-rt/CMakeLists define BUILDING_FLANGRT) .

================
Comment at: flang/runtime/CMakeLists.txt:251

-  INSTALL_WITH_TOOLCHAIN
-)
+if (DEFINED LLVM_ENABLE_RUNTIMES AND "flang-rt" IN_LIST LLVM_ENABLE_RUNTIMES)
+  add_flang_library(FortranRuntime STATIC
----------------
This "if" doesn't make sense to me.  If we're not building flang-rt, we shouldn't be here, so I don't see why you need an "if" in the first place.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154869/new/

https://reviews.llvm.org/D154869