[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 18 10:24:06 PDT 2023


tbaeder added a comment.

What if you switch from `IgnoreParenImpCasts` at the top of `DiagnoseStaticAssertDetails()` to just `IgnoreParens()`? That improve cases where we simply compare a character literal to an integer, since the literal should be implicitly cast to an integer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155610/new/

https://reviews.llvm.org/D155610



More information about the cfe-commits mailing list