[PATCH] D155619: [clangd] Always run preamble indexing on a separate thread
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 18 09:15:56 PDT 2023
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added a subscriber: arphaman.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This has been the default in our production setup for weeks now,
showing great improvements to latency and no problems around stability or
correctness of the results.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D155619
Files:
clang-tools-extra/clangd/ClangdServer.cpp
clang-tools-extra/clangd/ClangdServer.h
Index: clang-tools-extra/clangd/ClangdServer.h
===================================================================
--- clang-tools-extra/clangd/ClangdServer.h
+++ clang-tools-extra/clangd/ClangdServer.h
@@ -185,10 +185,6 @@
/// regions in the document.
bool PublishInactiveRegions = false;
- /// Whether to run preamble indexing asynchronously in an independent
- /// thread.
- bool AsyncPreambleIndexing = false;
-
explicit operator TUScheduler::Options() const;
};
// Sensible default options for use in tests.
Index: clang-tools-extra/clangd/ClangdServer.cpp
===================================================================
--- clang-tools-extra/clangd/ClangdServer.cpp
+++ clang-tools-extra/clangd/ClangdServer.cpp
@@ -94,7 +94,7 @@
ASTCtx.getPreprocessor(), *CanonIncludes);
};
- if (Opts.AsyncPreambleIndexing && Tasks) {
+ if (Tasks) {
Tasks->runAsync("Preamble indexing for:" + Path + Version,
std::move(Task));
} else
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155619.541593.patch
Type: text/x-patch
Size: 1040 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230718/ec7b8ac8/attachment.bin>
More information about the cfe-commits
mailing list