[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 18 08:07:23 PDT 2023


tbaeder added inline comments.


================
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:36
+/// Pushes \p Val to the stack, as a target-dependent 'int'.
+static void pushInt(InterpState &S, int32_t Val) {
+  const TargetInfo &TI = S.getCtx().getTargetInfo();
----------------
aaron.ballman wrote:
> Do we need the same for unsigned int as well? (I'm thinking in terms of pushing literal values like `0U`)
Theoretically yes, but all the ints we're pushing right now are signed AFAICS.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155568/new/

https://reviews.llvm.org/D155568



More information about the cfe-commits mailing list