[PATCH] D155573: [Clang] Fix the location of default init expressions

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/test/SemaCXX/source_location.cpp:796
+static_assert(S(0).i == S{0}.i);
+static_assert(S(0).j == S{0}.i);
+}
----------------
cor3ntin wrote:
> aaron.ballman wrote:
> > Shouldn't this test fail because `i != j`?
> > 
> > Can you add a test that demonstrates we've corrected the source location information for diagnostics?
> They should all be equal!
> 
> > Can you add a test that demonstrates we've corrected the source location information for diagnostics?
> 
> Hum, i was planning to do that in https://reviews.llvm.org/D155175. I can try to think of something there!
> They should all be equal!

Whaaaaa? Shouldn't `i == 790 && j == 791`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155573/new/

https://reviews.llvm.org/D155573