[PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class
Corentin Jabot via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 18 04:58:36 PDT 2023
cor3ntin added inline comments.
================
Comment at: clang/lib/CodeGen/CGDecl.cpp:1915-1924
LangOptions::TrivialAutoVarInitKind trivialAutoVarInit =
(D.isConstexpr()
? LangOptions::TrivialAutoVarInitKind::Uninitialized
: (D.getAttr<UninitializedAttr>()
? LangOptions::TrivialAutoVarInitKind::Uninitialized
- : getContext().getLangOpts().getTrivialAutoVarInit()));
+ : (isEmptyClass(D)
+ ? LangOptions::TrivialAutoVarInitKind::Uninitialized
----------------
Can we simplify the condition here? this cascade of ternaries is becoming hard to read.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155580/new/
https://reviews.llvm.org/D155580
More information about the cfe-commits
mailing list