[PATCH] D140745: Generate Config {Fragment structure, json schema, docs, YAML parser} from schema spec

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 17 22:46:17 PDT 2023


sammccall added a comment.

In D140745#4508559 <https://reviews.llvm.org/D140745#4508559>, @nridge wrote:

> In D140745#4505829 <https://reviews.llvm.org/D140745#4505829>, @sammccall wrote:
>
>> ping on this one for when you have time
>
> (Just wanted to double-check, is this ping directed to me or Kadir (or both)? I haven't looked at this because Kadir has done a round of review and it seemed like duplication of work for me to look at it as well; however, if you'd like me to do a round of review, I'm happy to!)

Oops, indeed it was directed at Kadir, we'd also discussed it offline at length a few months ago and I think this is mostly a question of cleaning up the details now.

Always happy to have more feedback or hear concerns, but no need unless you're interested (and this patch isn't that interesting :-D)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140745/new/

https://reviews.llvm.org/D140745



More information about the cfe-commits mailing list