[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage
Rashmi Mudduluru via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 17 16:36:54 PDT 2023
t-rasmud accepted this revision.
t-rasmud added a comment.
This revision is now accepted and ready to land.
LGTM!
================
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2346
+ // computed above. We do not want to generate fix-its for such variables,
+ // since they are neither warned nor reachable from a warned one.
+ for (auto I = FixablesForAllVars.byVar.begin();
----------------
Nit: Maybe also mention when a variable is neither warned nor is reachable? Are there scenarios besides variables inside pragmas where this constraint is satisfied?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155524/new/
https://reviews.llvm.org/D155524
More information about the cfe-commits
mailing list