[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 17 16:06:43 PDT 2023


shafik marked an inline comment as done.
shafik added inline comments.


================
Comment at: clang/include/clang/Sema/Lookup.h:197-200
+        DiagnoseAccess(std::move(Other.DiagnoseAccess)),
+        DiagnoseAmbiguous(std::move(Other.DiagnoseAmbiguous)),
         AllowHidden(std::move(Other.AllowHidden)),
         Shadowed(std::move(Other.Shadowed)),
----------------
cor3ntin wrote:
> these std::move are a bit superfluous :)
Yeah, I was just keeping consistent. I don't think they are doing any harm in this case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155387/new/

https://reviews.llvm.org/D155387



More information about the cfe-commits mailing list