[PATCH] D155501: Add new option -fkeep-persistent-storage-variables to Clang release notes

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 17 14:37:16 PDT 2023


hubert.reinterpretcast added inline comments.


================
Comment at: clang/docs/ReleaseNotes.rst:259-260
+- ``-fkeep-persistent-storage-variables`` has been implemented to keep all
+  variables that have a persistent storage duration, including global, static
+  and thread-local variables, to guarantee that they can be directly addressed.
 
----------------
Suggestion: Use em dashes to avoid overuse of commas.

Additionally, I am wondering if the release notes is a reasonable place to add something like: Since this inhibits the merging of the affected variables, the number of individual relocations in the program will generally increase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155501/new/

https://reviews.llvm.org/D155501



More information about the cfe-commits mailing list