[PATCH] D155509: Revert "Remove rdar links; NFC"

Mehdi AMINI via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 17 12:49:27 PDT 2023


mehdi_amini created this revision.
mehdi_amini added reviewers: lattner, aaron.ballman.
Herald added subscribers: steakhal, jdoerfert, martong, pengfei, arphaman.
Herald added a reviewer: NoQ.
Herald added a project: All.
mehdi_amini requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.

This reverts commit d618f1c3b12effd0c2bdb7d02108d3551f389d3d <https://reviews.llvm.org/rGd618f1c3b12effd0c2bdb7d02108d3551f389d3d>.
This commit wasn't reviewed ahead of time and significant concerns were
raised immediately after it landed. According to our developer policy
this warrants immediate revert of the commit.

https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155509

Files:
  clang/lib/Analysis/CFG.cpp
  clang/lib/Analysis/RetainSummaryManager.cpp
  clang/lib/CodeGen/CGObjCMac.cpp
  clang/lib/CodeGen/CodeGenModule.cpp
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/lib/Sema/SemaObjCProperty.cpp
  clang/lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp
  clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp
  clang/lib/StaticAnalyzer/Core/CallEvent.cpp
  clang/lib/StaticAnalyzer/Core/ExprEngineObjC.cpp
  clang/test/ARCMT/GC-check-warn-nsalloc.m
  clang/test/ARCMT/GC-no-finalize-removal.m
  clang/test/ARCMT/GC-no-finalize-removal.m.result
  clang/test/ARCMT/GC.m
  clang/test/ARCMT/GC.m.result
  clang/test/ARCMT/check-with-pch.m
  clang/test/ARCMT/checking.m
  clang/test/ARCMT/no-canceling-bridge-to-bridge-cast.m
  clang/test/ARCMT/nonobjc-to-objc-cast-2.m
  clang/test/ARCMT/objcmt-arc-cf-annotations.m
  clang/test/ARCMT/objcmt-arc-cf-annotations.m.result
  clang/test/ARCMT/objcmt-atomic-property.m
  clang/test/ARCMT/objcmt-atomic-property.m.result
  clang/test/ARCMT/objcmt-boxing.m
  clang/test/ARCMT/objcmt-boxing.m.result
  clang/test/ARCMT/objcmt-migrate-all.m
  clang/test/ARCMT/objcmt-migrate-all.m.result
  clang/test/ARCMT/objcmt-ns-macros.m
  clang/test/ARCMT/objcmt-ns-macros.m.result
  clang/test/ARCMT/objcmt-ns-nonatomic-iosonly.m
  clang/test/ARCMT/objcmt-ns-nonatomic-iosonly.m.result
  clang/test/ARCMT/objcmt-ns-returns-inner-pointer.m
  clang/test/ARCMT/objcmt-ns-returns-inner-pointer.m.result
  clang/test/ARCMT/objcmt-property-availability.m
  clang/test/ARCMT/objcmt-property-availability.m.result
  clang/test/ARCMT/objcmt-property-dot-syntax.m
  clang/test/ARCMT/objcmt-property-dot-syntax.m.result
  clang/test/ARCMT/objcmt-property.m
  clang/test/ARCMT/objcmt-property.m.result
  clang/test/ARCMT/objcmt-protocol-conformance.m
  clang/test/ARCMT/objcmt-protocol-conformance.m.result
  clang/test/ARCMT/objcmt-undefined-ns-macros.m
  clang/test/ARCMT/objcmt-undefined-ns-macros.m.result
  clang/test/Analysis/DeallocMissingRelease.m
  clang/test/Analysis/DeallocUseAfterFreeErrors.m
  clang/test/Analysis/Inputs/expected-plists/edges-new.mm.plist
  clang/test/Analysis/Inputs/expected-plists/inline-plist.c.plist
  clang/test/Analysis/Inputs/expected-plists/malloc-plist.c.plist
  clang/test/Analysis/Inputs/expected-plists/plist-output.m.plist
  clang/test/Analysis/Inputs/expected-plists/retain-release.m.objc.plist
  clang/test/Analysis/Inputs/expected-plists/retain-release.m.objcpp.plist
  clang/test/Analysis/NSString.m
  clang/test/Analysis/OSAtomic_mac.cpp
  clang/test/Analysis/PR46264.cpp
  clang/test/Analysis/UserNullabilityAnnotations.m
  clang/test/Analysis/array-struct-region.c
  clang/test/Analysis/blocks.m
  clang/test/Analysis/call-and-message.m
  clang/test/Analysis/call-invalidation.cpp
  clang/test/Analysis/cfref_rdar6080742.c
  clang/test/Analysis/dead-stores.c
  clang/test/Analysis/default-analyze.m
  clang/test/Analysis/delegates.m
  clang/test/Analysis/edges-new.mm
  clang/test/Analysis/generics.m
  clang/test/Analysis/inline-plist.c
  clang/test/Analysis/inlining/Inputs/expected-plists/path-notes.m.plist
  clang/test/Analysis/inlining/eager-reclamation-path-notes.c
  clang/test/Analysis/inlining/false-positive-suppression.c
  clang/test/Analysis/inlining/path-notes.m
  clang/test/Analysis/malloc-interprocedural.c
  clang/test/Analysis/malloc-plist.c
  clang/test/Analysis/malloc.c
  clang/test/Analysis/misc-ps-64.m
  clang/test/Analysis/misc-ps-arm.m
  clang/test/Analysis/misc-ps-eager-assume.m
  clang/test/Analysis/misc-ps-ranges.m
  clang/test/Analysis/misc-ps-region-store.cpp
  clang/test/Analysis/misc-ps-region-store.m
  clang/test/Analysis/misc-ps.m
  clang/test/Analysis/mutually_exclusive_null_fp.cpp
  clang/test/Analysis/nil-receiver-undefined-larger-than-voidptr-ret-region.m
  clang/test/Analysis/null-deref-ps.c
  clang/test/Analysis/objc-arc.m
  clang/test/Analysis/objc-encode.m
  clang/test/Analysis/objc-subscript.m
  clang/test/Analysis/osobject-retain-release.cpp
  clang/test/Analysis/plist-output-alternate.m
  clang/test/Analysis/plist-output.m
  clang/test/Analysis/properties.m
  clang/test/Analysis/properties.mm
  clang/test/Analysis/reference.cpp
  clang/test/Analysis/retain-release-inline.m
  clang/test/Analysis/retain-release-region-store.m
  clang/test/Analysis/retain-release.m
  clang/test/Analysis/retain-release.mm
  clang/test/Analysis/security-syntax-checks.m
  clang/test/Analysis/stack-addr-ps.c
  clang/test/Analysis/stack-addr-ps.cpp
  clang/test/Analysis/templates.cpp
  clang/test/Analysis/uninit-bug-first-iteration-init.c
  clang/test/Analysis/uninit-exhaustive-switch-bug.c
  clang/test/Analysis/uninit-ps-rdar6145427.m
  clang/test/Analysis/uninit-vals.c
  clang/test/Analysis/uninit-vals.m
  clang/test/Analysis/unused-ivars.m
  clang/test/CXX/basic/basic.lookup/basic.lookup.elab/p2.cpp
  clang/test/CXX/basic/basic.lookup/basic.lookup.unqual/p14.cpp
  clang/test/CXX/class.access/class.access.base/p5.cpp
  clang/test/CXX/class.access/class.friend/p11.cpp
  clang/test/CXX/class.access/class.protected/p1.cpp
  clang/test/CXX/class.access/p4.cpp
  clang/test/CXX/class.access/p6.cpp
  clang/test/CXX/class.derived/class.member.lookup/p8.cpp
  clang/test/CXX/dcl.dcl/basic.namespace/namespace.def/namespace.memdef/p3.cpp
  clang/test/CXX/dcl.dcl/basic.namespace/namespace.udir/p6.cpp
  clang/test/CXX/dcl.decl/dcl.init/p6.cpp
  clang/test/CXX/dcl.decl/dcl.meaning/dcl.array/p3.cpp
  clang/test/CXX/expr/expr.const/p3-0x-nowarn.cpp
  clang/test/CXX/expr/expr.unary/expr.unary.op/p4.cpp
  clang/test/CXX/over/over.match/over.match.best/over.best.ics/over.ics.list/p6.cpp
  clang/test/CXX/temp/temp.decls/temp.friend/p5.cpp
  clang/test/CXX/temp/temp.spec/temp.inst/p11.cpp
  clang/test/CodeGen/2008-07-30-implicit-initialization.c
  clang/test/CodeGen/2008-07-30-redef-of-bitcasted-decl.c
  clang/test/CodeGen/2008-08-04-void-pointer-arithmetic.c
  clang/test/CodeGen/2009-01-05-BlockInlining.c
  clang/test/CodeGen/2009-06-18-StaticInitTailPadPack.c
  clang/test/CodeGen/2010-01-13-MemBarrier.c
  clang/test/CodeGen/2010-02-15-DbgStaticVar.c
  clang/test/CodeGen/2010-05-26-AsmSideEffect.c
  clang/test/CodeGen/2010-07-08-DeclDebugLineNo.c
  clang/test/CodeGen/2010-08-12-asm-aggr-arg.c
  clang/test/CodeGen/X86/x86_32-arguments-darwin.c
  clang/test/CodeGen/X86/x86_32-arguments-linux.c
  clang/test/CodeGen/X86/x86_32-inline-asm.c
  clang/test/CodeGen/X86/x86_64-arguments-darwin.c
  clang/test/CodeGen/X86/x86_64-arguments.c
  clang/test/CodeGen/alignment.c
  clang/test/CodeGen/arm-apcs-zerolength-bitfield.c
  clang/test/CodeGen/arm-arguments.c
  clang/test/CodeGen/arm-asm-diag.c
  clang/test/CodeGen/arm-asm-warn.c
  clang/test/CodeGen/arm-neon-misc.c
  clang/test/CodeGen/arm-vector-align.c
  clang/test/CodeGen/arm64-arguments.c
  clang/test/CodeGen/arm64_vdupq_n_f64.c
  clang/test/CodeGen/asm-inout.c
  clang/test/CodeGen/asm.c
  clang/test/CodeGen/asm_arm64.c
  clang/test/CodeGen/atomic-arm64.c
  clang/test/CodeGen/atomic.c
  clang/test/CodeGen/attr-cleanup.c
  clang/test/CodeGen/attr-weak-import.c
  clang/test/CodeGen/bitfield-2.c
  clang/test/CodeGen/block-3.c
  clang/test/CodeGen/block-byref-aggr.c
  clang/test/CodeGen/block-with-predefinedexpr.c
  clang/test/CodeGen/blocks.c
  clang/test/CodeGen/blocksignature.c
  clang/test/CodeGen/blockstret.c
  clang/test/CodeGen/builtin-attributes.c
  clang/test/CodeGen/builtin-expect.c
  clang/test/CodeGen/builtin-memfns.c
  clang/test/CodeGen/builtins-overflow.c
  clang/test/CodeGen/byval-memcpy-elim.c
  clang/test/CodeGen/c11atomics-ios.c
  clang/test/CodeGen/capture-complex-expr-in-block.c
  clang/test/CodeGen/cfstring.c
  clang/test/CodeGen/cfstring2.c
  clang/test/CodeGen/complex-builtins-3.c
  clang/test/CodeGen/complex.c
  clang/test/CodeGen/conditional-gnu-ext.c
  clang/test/CodeGen/conditional.c
  clang/test/CodeGen/debug-info-block-decl.c
  clang/test/CodeGen/debug-info-crash.c
  clang/test/CodeGen/debug-info-file-change.c
  clang/test/CodeGen/debug-info-line2.c
  clang/test/CodeGen/debug-info-scope.c
  clang/test/CodeGen/debug-info.c
  clang/test/CodeGen/decl.c
  clang/test/CodeGen/designated-initializers.c
  clang/test/CodeGen/dostmt.c
  clang/test/CodeGen/exceptions-strictfp.c
  clang/test/CodeGen/exceptions.c
  clang/test/CodeGen/exprs.c
  clang/test/CodeGen/ext-vector.c
  clang/test/CodeGen/func-aligned.c
  clang/test/CodeGen/func-in-block.c
  clang/test/CodeGen/function-attributes.c
  clang/test/CodeGen/functions.c
  clang/test/CodeGen/global-init.c
  clang/test/CodeGen/implicit-arg.c
  clang/test/CodeGen/init.c
  clang/test/CodeGen/inline.c
  clang/test/CodeGen/integer-overflow.c
  clang/test/CodeGen/libcalls-fno-builtin.c
  clang/test/CodeGen/ms-inline-asm.cpp
  clang/test/CodeGen/ms_struct-bitfield-1.c
  clang/test/CodeGen/ms_struct-bitfield-2.c
  clang/test/CodeGen/ms_struct-bitfield-3.c
  clang/test/CodeGen/ms_struct-bitfield-init.c
  clang/test/CodeGen/ms_struct-bitfield.c
  clang/test/CodeGen/ms_struct-pack.c
  clang/test/CodeGen/no-opt-volatile-memcpy.c
  clang/test/CodeGen/noinline.c
  clang/test/CodeGen/packed-nest-unpacked.c
  clang/test/CodeGen/pascal-wchar-string.c
  clang/test/CodeGen/pointer-to-int.c
  clang/test/CodeGen/pragma-pack-2.c
  clang/test/CodeGen/pragma-pack-3.c
  clang/test/CodeGen/private-extern-redef.c
  clang/test/CodeGen/redef-ext-inline.c
  clang/test/CodeGen/sanitize-blocks.c
  clang/test/CodeGen/struct-init.c
  clang/test/CodeGen/switch-dce.c
  clang/test/CodeGen/switch.c
  clang/test/CodeGen/transparent-union-redecl.c
  clang/test/CodeGen/union-align.c
  clang/test/CodeGen/unwind-attr.c
  clang/test/CodeGen/utf16-cfstrings.c
  clang/test/CodeGen/vector-alignment.c
  clang/test/CodeGen/visibility.c
  clang/test/CodeGen/vla.c
  clang/test/CodeGenCXX/2008-01-12-VecInit.cpp
  clang/test/CodeGenCXX/2008-05-07-CrazyOffsetOf.cpp
  clang/test/CodeGenCXX/2009-08-05-ZeroInitWidth.cpp
  clang/test/CodeGenCXX/2009-08-11-VectorRetTy.cpp
  clang/test/CodeGenCXX/2009-10-27-crash.cpp
  clang/test/CodeGenCXX/2012-03-16-StoreAlign.cpp
  clang/test/CodeGenCXX/align-avx-complete-objects.cpp
  clang/test/CodeGenCXX/anonymous-union-member-initializer.cpp
  clang/test/CodeGenCXX/apple-kext-guard-variable.cpp
  clang/test/CodeGenCXX/apple-kext-linkage.cpp
  clang/test/CodeGenCXX/apple-kext-no-staticinit-section.cpp
  clang/test/CodeGenCXX/apple-kext.cpp
  clang/test/CodeGenCXX/arm.cpp
  clang/test/CodeGenCXX/arm64-constructor-return.cpp
  clang/test/CodeGenCXX/arm64.cpp
  clang/test/CodeGenCXX/armv7k.cpp
  clang/test/CodeGenCXX/asm.cpp
  clang/test/CodeGenCXX/attr-used.cpp
  clang/test/CodeGenCXX/block-byref-cxx-objc.cpp
  clang/test/CodeGenCXX/blocks-cxx11.cpp
  clang/test/CodeGenCXX/blocks.cpp
  clang/test/CodeGenCXX/class-layout.cpp
  clang/test/CodeGenCXX/conditional-gnu-ext.cpp
  clang/test/CodeGenCXX/copy-assign-volatile-synthesis.cpp
  clang/test/CodeGenCXX/copy-constructor-synthesis.cpp
  clang/test/CodeGenCXX/cxx-block-objects.cpp
  (994 more files...)



More information about the cfe-commits mailing list