[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added inline comments.


================
Comment at: clang/test/Sema/asm-goto.cpp:71
+l1:;
+}
----------------
cor3ntin wrote:
> can you add more tests? Maybe something like that
> 
> ```cpp
> void f() {
>   try{
>     __label__ label;
>     asm goto("" : : : : label);
>     label:;
>   }
>   catch(...){
>     __label__ label;
>     asm goto("" : : : : label);
>     label:;
>   };
>   if constexpr(false) {
>     __label__ label;
>     asm goto("" : : : : label);
>     label:;
>   }
> }
> ```
Done, but I have to put it somewhere else because:
1. exceptions are disabled in clang/test/Sema/*. This needs to go in clang/test/SemaCXX/
2. `if constexpr` is a C++17 addition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155342/new/

https://reviews.llvm.org/D155342