[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

Mon Jul 17 06:04:32 PDT 2023

tomasz-kaminski-sonarsource marked an inline comment as done.
tomasz-kaminski-sonarsource added inline comments.

================
Comment at: clang/test/Analysis/lifetime-cfg-output.cpp:760
 // CHECK-NEXT:    2: [B1.1]++
-// CHECK-NEXT:    3: [B2.2] (Lifetime ends)
-// CHECK-NEXT:    4: [B3.1] (Lifetime ends)
+// CHECK-NEXT:    3: [B2.4] (Lifetime ends)
+// CHECK-NEXT:    4: [B2.2] (Lifetime ends)
----------------
xazax.hun wrote:
> Would it be possible to add the variable name to the lifetime ends dumps? It would make interpreting these tests somewhat easier. (It is OK as a separate/follow-up patch.)
I think that would indeed be helpful. We could do the same for the destructors:
> [B3.3].~A() (Implicit destructor)
But to be explicit, I do not have any idea when I would be able to work on it. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153273/new/

https://reviews.llvm.org/D153273