[PATCH] D155147: Add SM3 instructions.

[Simon Pilgrim via Phabricator via cfe-commits]

RKSimon added inline comments.


================
Comment at: clang/lib/Headers/sm3intrin.h:21
+
+static __inline__ __m128i __DEFAULT_FN_ATTRS128 _mm_sm3msg1_epi32(__m128i __A,
+                                                                  __m128i __B,
----------------
Doxygen descriptions?


================
Comment at: llvm/test/MC/Disassembler/X86/sm3-64.txt:4
+
+# RUN: llvm-mc --disassemble %s -triple=x86_64 | FileCheck %s --check-prefixes=ATT
+# RUN: llvm-mc --disassemble %s -triple=x86_64 -x86-asm-syntax=intel --output-asm-variant=1 | FileCheck %s --check-prefixes=INTEL
----------------
FreddyYe wrote:
> pengfei wrote:
> > We can merge 64-bit tests into 32-bit ones. The same below.
> Due to these instructions support  rm form, hard to merge here?
I'd prefer to see 32/64 test coverage kept separate, but it'd be more useful for 64 to use xmm8-xmm15 and 64-specific gpr registers etc. to increase coverage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155147/new/

https://reviews.llvm.org/D155147