[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()
Corentin Jabot via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jul 16 23:30:25 PDT 2023
cor3ntin accepted this revision.
cor3ntin added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:166-168
+ // FIXME: We are not going through getParam() here, because the function
+ // doesn't have any parameters. Wait for a pattern to emerge and maybe
+ // refactor this into a different function that checks things are valid.
----------------
I would remove the fixme, given you already implemented all the floating point builtins
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155369/new/
https://reviews.llvm.org/D155369
More information about the cfe-commits
mailing list