[PATCH] D155392: [clangd] add a config knob to disable modules
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Jul 15 23:56:43 PDT 2023
sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp:497
TEST(DocumentSymbols, ExportContext) {
+ Config EnableModules;
+ EnableModules.CompileFlags.NaiveModules = true;
----------------
For existing tests of how modules interacts with other features, testing these with modules-enabled seems sufficient.
For tests that were specifically about modules, I think it makes sense to test in both modes (behavior may differ).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155392/new/
https://reviews.llvm.org/D155392
More information about the cfe-commits
mailing list