[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 15 22:04:41 PDT 2023


shafik created this revision.
shafik added reviewers: aaron.ballman, rsmith, cor3ntin.
Herald added a project: All.
shafik requested review of this revision.

There are some cases during member lookup we are aggressively suppressing diagnostics when we should just be suppressing access control diagnostic.

In this PR I add the ability to simply suppress access diagnostics while not suppressing ambiguous lookup diagnostics.

Fixes: https://github.com/llvm/llvm-project/issues/22413 
https://github.com/llvm/llvm-project/issues/29942
https://github.com/llvm/llvm-project/issues/35574


https://reviews.llvm.org/D155387

Files:
  clang/include/clang/Sema/Lookup.h
  clang/lib/Sema/SemaOverload.cpp
  clang/lib/Sema/SemaTemplate.cpp
  clang/test/CXX/class.derived/class.member.lookup/gh22413.cpp
  clang/test/CXX/class.derived/class.member.lookup/p11.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155387.540755.patch
Type: text/x-patch
Size: 7927 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230716/915e3ed7/attachment.bin>


More information about the cfe-commits mailing list