[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 15 13:24:13 PDT 2023


sammccall added a comment.

In D153946#4503585 <https://reviews.llvm.org/D153946#4503585>, @sammccall wrote:

> - maybe we can come up with some heuristics to improve the "no reserved names" rule, with or without configuration. (Maybe apply it to only -isystem headers? Linux uses angle-quoted includes, but not actually `-isystem` AFAICS)

I tried this out, and it behaves well at least for linux & the C++ stdlib on my system. D155381 <https://reviews.llvm.org/D155381> if you like the approach.

I have the feeling there may still be some exceptions, but we don't know about them yet and it sidesteps the config questions...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153946/new/

https://reviews.llvm.org/D153946



More information about the cfe-commits mailing list