[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

[Björn Schäpers via Phabricator via cfe-commits]

HazardyKnusperkeks added inline comments.


================
Comment at: clang/include/clang/Format/Format.h:4220
   /// \version 3.7
   bool SpacesInParentheses;
 
----------------
The deprecated options should be removed from the struct, see `AllowAllConstructorInitializersOnNextLine` for an example.

You also need to adapt the parsing logic a bit.


================
Comment at: clang/lib/Format/Format.cpp:735
+
+    // For backward compatibility.
+    IO.enumCase(Value, "false", FormatStyle::SIPO_Never);
----------------
Since the option is new, there is no backward. You can drop this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155239/new/

https://reviews.llvm.org/D155239