[PATCH] D154093: [clang-format] Break long strings in Verilog

[Björn Schäpers via Phabricator via cfe-commits]

HazardyKnusperkeks added inline comments.


================
Comment at: clang/lib/Format/ContinuationIndenter.cpp:2247
                                            bool DryRun, bool Strict) {
-  std::unique_ptr<const BreakableToken> Token =
+  std::unique_ptr<BreakableToken> Token =
       createBreakableToken(Current, State, AllowBreak);
----------------
This const can be readded, or not?


================
Comment at: clang/lib/Format/WhitespaceManager.cpp:1428
+      // case, it is allowed if there is a replacement for the empty range
+      // between 2 tokens and another non-empty range at the start of the second
+      // token.
----------------
Can you elaborate where the 2 replacements come from, and why we can't make sure there is no empty range?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154093/new/

https://reviews.llvm.org/D154093