[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

[Corentin Jabot via Phabricator via cfe-commits]

cor3ntin added inline comments.


================
Comment at: clang/lib/Sema/JumpDiagnostics.cpp:791-800
+      // This unnecessary copy is because:
+      // warning: captured structured bindings are a C++20 extension
+      // [-Wc++20-extensions]
+      LabelDecl *TL = TargetLabel;
+      // Is TargetLabel one of the targets of the JumpStmt? If not, then skip
+      // it.
+      if (IsAsmGoto &&
----------------
cor3ntin wrote:
> I don't think the pointer adds that much, you can init capture by copy which simplifies a bit 
> I don't think the pointer adds that much, you can init capture by copy which simplifies a bit 

s/pointer/comment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155342/new/

https://reviews.llvm.org/D155342