[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

David Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 14 11:56:26 PDT 2023


davidxl added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:795
-  /* When PNS >= OldPNS, the last one wins. */
-  if (!FilenamePat || parseFilenamePattern(FilenamePat, CopyFilenamePat))
     resetFilenameToDefault();
----------------
what is this change for?


================
Comment at: compiler-rt/test/profile/Posix/instrprof-fork.c:10
+// RUN: PROFILE2=`tail -n 1 %t.out`
+// RUN: ls $PROFILE2
+
----------------
add some dump and check to make sure profiles are not truncated?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155290/new/

https://reviews.llvm.org/D155290



More information about the cfe-commits mailing list