[PATCH] D155213: [HIP] Add `-fno-hip-uniform-block`

Siu Chi Chan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 14 10:41:43 PDT 2023


scchan added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:1092
   ShouldParseIf<hip.KeyPath>;
+defm hip_uniform_block : BoolFOption<"hip-uniform-block",
+  LangOpts<"HIPUniformBlock">, DefaultTrue,
----------------
arsenm wrote:
> Can we avoid adding yet another language flag for something that's reusable for everything? Is there an --offload-<something> ?
Don't we need a different default value for some languages like OpenCL?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155213/new/

https://reviews.llvm.org/D155213



More information about the cfe-commits mailing list