[PATCH] D154123: [HIP] Start document HIP support by clang

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked 2 inline comments as done.
yaxunl added inline comments.


================
Comment at: clang/docs/HIPSupport.rst:49
+
+You can also use ``--offload-arch=native`` to let ``amdgpu-arch`` automatically detect the GPU architecture on your system:
+
----------------
arsenm wrote:
> s/architecture/architectures
done


================
Comment at: clang/docs/HIPSupport.rst:99
+
+Note: The compiler options override environment variables. Specifying HIP runtime and device library paths individually will override the ROCm path.
+
----------------
arsenm wrote:
> We should really not have the environment variables I wouldn't go out of the way to advertise them, just mark as deprecated
added warnings to discourage use of env vars


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154123/new/

https://reviews.llvm.org/D154123