[PATCH] D155217: [clang-tidy][include-cleaner] Don't warn for the same symbol twice

Piotr Zegar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 14 08:01:24 PDT 2023


PiotrZSL added a comment.

Check emits warnings per symbol/usage, but fixes header includes, won't it make duplicate includes ?

Problem that I see is that multiple warnings for same symbol will generate lot of noise.
And when dealing with diff why developer should be forced to fix legacy issues just because he/she used same symbol, after all issue is actually peer symbol, whatever how many times is used.
Stil...

I cannot make "decision" here.
Both patch author, and check author got a point.

There is only one option, could this be made configurable ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155217/new/

https://reviews.llvm.org/D155217



More information about the cfe-commits mailing list