[PATCH] D155213: [HIP] Add `-fno-hip-uniform-block`

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked 2 inline comments as done.
yaxunl added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7226
+  } else {
+    Args.claimAllArgs(options::OPT_fhip_uniform_block,
+                      options::OPT_fno_hip_uniform_block);
----------------
MaskRay wrote:
> yaxunl wrote:
> > MaskRay wrote:
> > > Why is the -Wunused-command-line-argument warning suppressed in non-IsHIP mode?
> > Users may want to add these options to clang config file.
> > 
> > Is there a general rule which options should be claimed?
> Options in a configuration file are automatically claimed.
> 
> I don't know a general rule, but we generally don't claim newly introduced options.
I think I should remove the claimAllArgs for this option. It should behave like the usual options when not used.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155213/new/

https://reviews.llvm.org/D155213