[PATCH] D148654: Modify BoundsSan to improve debuggability

[Arthur Eubanks via Phabricator via cfe-commits]

aeubanks added inline comments.


================
Comment at: clang/lib/CodeGen/CGExpr.cpp:3594
+        TrapCall->addFnAttr(A);
+      }
+      TrapCall->setDoesNotReturn();
----------------
oskarwirga wrote:
> vitalybuka wrote:
> > wouldn't be you issues solved with
> > TrapCall->setCannotMerge() here?
> ubsantrap gets lowered to an instruction in MIR which then gets merged later. This was the only way I was able to create unique instruction per check. 
isn't that a `nomerge` bug that should get fixed instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148654/new/

https://reviews.llvm.org/D148654