[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 13 13:07:44 PDT 2023
efriedma added a comment.
In D86310#4498721 <https://reviews.llvm.org/D86310#4498721>, @hvdijk wrote:
> In D86310#4498575 <https://reviews.llvm.org/D86310#4498575>, @efriedma wrote:
>
>> https://reviews.llvm.org/D86310#2231136 has an example where IR generated by clang breaks.
>
> clang bases it on the data layout, so when the change here is applied, clang already generates correct IR for that example without further changes (using `%struct.Y = type <{ i64, %struct.X }>`). Unless you were using that as an example of when using old clang to generate LLVM IR, and new LLVM to produce machine code, would break?
I only meant to dispute the assertion that ABI compatibility with old IR is only a problem for non-clang frontends.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86310/new/
https://reviews.llvm.org/D86310
More information about the cfe-commits
mailing list