[PATCH] D154688: [clang] Show verify prefix in error messages

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D154688#4497967 <https://reviews.llvm.org/D154688#4497967>, @tbaeder wrote:

> When passing a different prefix via `-verify=foo`, the error messages now say "error: 'foo-error' diagnostics seen but not expected", etc.
>
> I'm often working in test files where two different prefixes are used and I'm always confused about which one of the two the error messages are talking about.

What I'm confused by is that we list the line numbers of the failures, so the prefix only seems like it's helpful in a case where two prefixes use the same message and the same severity on the same line. e.g., `// foo-error {{whatever}} bar-error {{whatever}}`. In the other cases, either the line number is different, or the severity is different, or the message is different which I thought was giving sufficient context.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154688/new/

https://reviews.llvm.org/D154688