[PATCH] D155145: Add AVX-VNNI-INT16 instructions.

[Phoebe Wang via Phabricator via cfe-commits]

pengfei added inline comments.


================
Comment at: clang/lib/Basic/Targets/X86.cpp:1059
       .Case("avx512vp2intersect", HasAVX512VP2INTERSECT)
+      .Case("avxvnniint16", HasAVXVNNIINT16)
       .Case("avxifma", HasAVXIFMA)
----------------
alphabetical order.


================
Comment at: llvm/test/CodeGen/X86/avxvnniint16-intrinsics.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -verify-machineinstrs -mtriple=x86_64-unknown-unknown --show-mc-encoding -mattr=+avx2,+avxvnniint16 | FileCheck %s --check-prefixes=X64
+; RUN: llc < %s -verify-machineinstrs -mtriple=i686-unknown-unknown --show-mc-encoding -mattr=+avx2,+avxvnniint16 | FileCheck %s --check-prefixes=X86
----------------
`X64,CHECK`


================
Comment at: llvm/test/CodeGen/X86/avxvnniint16-intrinsics.ll:3
+; RUN: llc < %s -verify-machineinstrs -mtriple=x86_64-unknown-unknown --show-mc-encoding -mattr=+avx2,+avxvnniint16 | FileCheck %s --check-prefixes=X64
+; RUN: llc < %s -verify-machineinstrs -mtriple=i686-unknown-unknown --show-mc-encoding -mattr=+avx2,+avxvnniint16 | FileCheck %s --check-prefixes=X86
+
----------------
`X86,CHECK`


================
Comment at: llvm/test/CodeGen/X86/stack-folding-int-avxvnniint16.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -O3 -disable-peephole -verify-machineinstrs -mtriple=x86_64-unknown-unknown --show-mc-encoding -mattr=+avx2,+avxvnniint16 | FileCheck %s
+
----------------
Is this required?


================
Comment at: llvm/test/CodeGen/X86/stack-folding-int-avxvnniint16.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -O3 -disable-peephole -verify-machineinstrs -mtriple=x86_64-unknown-unknown --show-mc-encoding -mattr=+avx2,+avxvnniint16 | FileCheck %s
+
----------------
pengfei wrote:
> Is this required?
Don't need `avx2`


================
Comment at: llvm/test/MC/Disassembler/X86/avx-vnni-int16.txt:1
+
+# RUN: llvm-mc --disassemble %s -triple=i386-unknown-unknown | FileCheck %s --check-prefixes=ATT
----------------
Remove blank line.


================
Comment at: llvm/test/MC/Disassembler/X86/x86-64-avx-vnni-int16.txt:1-2
+
+# isadb version: 90b0204ffb4d39b8a5726db9c49d298aea6164f8
+
----------------
Remove this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155145/new/

https://reviews.llvm.org/D155145