[PATCH] D153881: Create diagnostic group for definition deprecation warning

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM! Do you need me to land this on your behalf? If so, what name and email address would you like me to use for patch attribution? (If I'm landing it, I can fix up the release note for you when landing.)



================
Comment at: clang/docs/ReleaseNotes.rst:373-376
+- A new diagnostic warning group ``deprecated-redundant-constexpr-static-def`` is
+  added. This is to be used to control warnings about out-of-line definitions of
+  static constexpr members that are unnecessary with ``-std=C++17`` onwards. The
+  diagnostic was previously only controllable via `-Wdeprecated`.
----------------
nuriamari wrote:
> Happy to use a better flag name, if anyone has ideas. Considered expanding to be more descriptive, but its already quite long.
Reworded a bit


================
Comment at: clang/test/SemaCXX/redundant-out-of-line-static-constexpr-member-def-diag.cpp:9
+  constexpr int A::n; // expected-warning{{out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated}}
+  const int A::m; // expected-warning{{out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated}}
+}
----------------
nuriamari wrote:
> Unbeknownst to me, the `const` variant of this diagnostic (still about a static constexpr member, but defined out-of-line with const) is already controlled via the same diagnostic group. Is this the behavior you expect @aaron.ballman?
Oh, nice! I wasn't aware we already covered that under the same group.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153881/new/

https://reviews.llvm.org/D153881