[PATCH] D151730: [RISCV] Support target attribute for function

Jessica Clarke via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 12 23:40:03 PDT 2023


jrtc27 added a comment.

- Asm tests are a no in Clang
- You seem to have some crazy long lists that I doubt need to be that long for test coverage (nor do you need so many variations, surely)
- CHECL is not CHECK
- You have some very strange spacing in CHECK lines


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151730/new/

https://reviews.llvm.org/D151730



More information about the cfe-commits mailing list