[PATCH] D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

Wed Jul 12 15:28:51 PDT 2023

MaskRay added a comment.

In D152604#4494975 <https://reviews.llvm.org/D152604#4494975>, @rnk wrote:

> It sounds like two users have hit this now: Chromium and Rust folks. This is a flag flip, so it's pretty small and safe to rollback, and IMO we should consider that while we debug the underlying issue.

Chromium's https://crbug.com/1459233 is also a Rust issue. All the evidence so far has shown that there is some issue with Rust or how Chromium and Firefox mix C++ and Rust, probably due to a special use case of LTO+asan.
I don't find justification to revert this Clang Driver change.
Chromium's https://crbug.com/1459233 seems to suggest that it has its own compiler-rt ODR violation issue and should be fixed there. Adding `-fno-sanitize-address-globals-dead-stripping` can be quite good workaround.

If we do identify a good reason to revert, we will consider reverting, but a downstream language implementation or its user does unsupported things which worked well and now broke due to a changed clang driver default does not seem a strong enough justification.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152604/new/

https://reviews.llvm.org/D152604