[PATCH] D151730: [RISCV] Support target attribute for function

Philip Reames via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 12 11:10:05 PDT 2023


reames added a comment.

In D151730#4491786 <https://reviews.llvm.org/D151730#4491786>, @craig.topper wrote:

> In D151730#4491773 <https://reviews.llvm.org/D151730#4491773>, @jrtc27 wrote:
>
>> Isn't multiversioning a separate thing that builds on top of per-function target attributes?
>
> That's what I thought. The supportsMultiVersioning call was in an earlier version of the patch that I asked about.

Yeah, looks like I got confused.

I hadn't expected that target("default") would automatically be considered multi-versioning, even when there was one definition of the function.  As such, my test case was accidentally testing multi-versioning even when I hadn't meant to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151730/new/

https://reviews.llvm.org/D151730



More information about the cfe-commits mailing list