[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 12 08:55:13 PDT 2023


craig.topper added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:4816
+  case RISCVVector::BI__builtin_rvv_vfadd_vf_rm_tu:
+  case RISCVVector::BI__builtin_rvv_vfadd_vv_rm_tama:
+  case RISCVVector::BI__builtin_rvv_vfadd_vf_rm_tama:
----------------
not related to this patch, but the tama here doesn't match the intrinsic naming.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:5740
+let mayRaiseFPException = true,
+    hasPostISelHook = 1 in {
+defm PseudoVFADD  : VPseudoVALU_VV_VF_RM;
----------------
Keep the `let` on one line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152996/new/

https://reviews.llvm.org/D152996



More information about the cfe-commits mailing list