[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.
Balázs Benics via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 12 07:10:28 PDT 2023
steakhal added inline comments.
================
Comment at: clang/test/Analysis/stream-note.c:61-62
FILE *F1 = fopen("foo1.c", "r"); // expected-note {{Stream opened here}}
+ // stdargs-note at -1 {{'fopen' is successful}}
+ // stdargs-note at -2 {{'fopen' is successful}}
if (!F1)
----------------
balazske wrote:
> steakhal wrote:
> > Why are these notes doubled?
> There are 2 cases of resource leak reported (for `F1` and `F2`) and a note tag is there for both of these.
I still think we should only have a single note there given that `F2` is completely unrelated to the initialization of `F1`.
Do I miss something?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153612/new/
https://reviews.llvm.org/D153612
More information about the cfe-commits
mailing list