[PATCH] D155081: Specify the developer policy around links to external resources

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 12 06:35:33 PDT 2023


aaron.ballman added inline comments.


================
Comment at: llvm/docs/DeveloperPolicy.rst:359
+  If the patch fixes a bug in GitHub Issues, we encourage adding
+  "Fixes https://github.com/llvm/llvm-project/issues/12345" to automate closing
+  the issue in GitHub. If the patch has been reviewed, we encourage adding a
----------------
arsenm wrote:
> I haven't quite figured out what the exact syntaxes which are automatically recognized. It seems to recognize "Fixes #Nxyz"
Yup, it does support that form as well. I had heard more than once during code review that folks seem to prefer the full link because it's easier to click on that from the commit message than it is to navigate to the fix from the number alone. That seemed like a pretty good reason to recommend the full form, but I don't have strong opinions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155081/new/

https://reviews.llvm.org/D155081



More information about the cfe-commits mailing list